Skip to content

Conversation

utkarshsharma1
Copy link

@utkarshsharma1 utkarshsharma1 commented Oct 6, 2025

Purpose

We are renaming tpu_commons package to tpu_inference. This is being done for public release.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@utkarshsharma1 utkarshsharma1 marked this pull request as draft October 6, 2025 06:16
@mergify mergify bot added v1 tpu Related to Google TPUs labels Oct 6, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase by renaming the tpu_commons package to tpu_inference. The changes are consistent across all modified files, including updates to import statements, variable names, and log messages. The refactoring appears to be comprehensive within the scope of the provided changes. I have reviewed the patches and found no issues of high or critical severity.

@utkarshsharma1 utkarshsharma1 marked this pull request as ready for review October 6, 2025 06:40
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaochengji yaochengji changed the title Rename tpu_commons to tpu_inference [TPU] Rename tpu_commons to tpu_inference Oct 6, 2025
@NickLucche NickLucche added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 7, 2025
@utkarshsharma1 utkarshsharma1 force-pushed the main branch 2 times, most recently from c73fbfa to 9fcab70 Compare October 7, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants